Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve experience when using Jinja to iterate over objects DATANG-3679 #14

Merged
merged 10 commits into from
Mar 27, 2024
Merged

Fix and improve experience when using Jinja to iterate over objects DATANG-3679 #14

merged 10 commits into from
Mar 27, 2024

Conversation

samsucik
Copy link
Collaborator

@samsucik samsucik commented Mar 26, 2024 •
edited
Loading

No description provided.

@samsucik samsucik marked this pull request as ready for review March 27, 2024 13:01
@samsucik samsucik requested a review from sweco March 27, 2024 13:01
sweco
sweco approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@sweco sweco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two tiny comments!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
prompterator/utils.py Show resolved Hide resolved
sweco
sweco reviewed Mar 27, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@samsucik samsucik merged commit 1ec8472 into main Mar 27, 2024
1 check passed
@samsucik samsucik deleted the samko/improve-jinja-experience branch March 27, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweco sweco sweco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsucik @sweco